fix: small toolbar fixes #1777
fix: small toolbar fixes #1777
Conversation
|
/create-server |
size-limit report 📦
|
Codecov ReportBase: 66.30% // Head: 66.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1777 +/- ##
==========================================
+ Coverage 66.30% 66.43% +0.13%
==========================================
Files 170 170
Lines 5557 5548 -9
Branches 1260 1251 -9
==========================================
+ Hits 3684 3685 +1
+ Misses 1864 1854 -10
Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
added missing divider Screen.Recording.2022-11-30.at.13.57.07.mov |
|
/create-server |
dogfrogfog
changed the title
|
For documentation purposes: Why are we adding a |
| ), | ||
| // sandwich view is hidden in diff view | ||
| width: TOOLBAR_SQUARE_WIDTH * (flamegraphType === 'single' ? 4 : 3), | ||
| width: TOOLBAR_SQUARE_WIDTH * (flamegraphType === 'single' ? 4 : 3), // 1px is to display divider |
There was a problem hiding this comment.
Just seeing this now, but it feels flaky...Ideally I would have 2 sets of const ToolbarItems = ToolbarItem[], one for single and another for double, then calculations would be derived from that.
(You don't have to act on it, I am just thinking out loud)
|
I approved this PR but just found that vertical margins for dividers are differing
|
Co-authored-by: eduardo aleixo <eh-am@users.noreply.github.com>
fixed |
|
/create-server |
Changes
Screen.Recording.2022-11-30.at.13.35.05.mov