Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): Tags are not being displayed #1784

Merged
merged 1 commit into from
Dec 1, 2022
Merged

fix(webapp): Tags are not being displayed #1784

merged 1 commit into from
Dec 1, 2022

Conversation

pavelpashkovsky
Copy link
Contributor

@pavelpashkovsky pavelpashkovsky commented Dec 1, 2022

Brief

Changes

  • loading tag value when user hovering on tag. Loading indicator during tag values loading process

DEMO: https://pr-1784.pyroscope.io/

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 501.82 KB (+0.02% 🔺) 10.1 s (+0.02% 🔺) 4 s (+5.05% 🔺) 14 s
webapp/public/assets/app.css 19.69 KB (+0.15% 🔺) 394 ms (+0.15% 🔺) 0 ms (+100% 🔺) 394 ms
webapp/public/assets/styles.css 9.58 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 129.97 KB (0%) 2.6 s (0%) 1.2 s (-8.87% 🔽) 3.8 s
packages/pyroscope-flamegraph/dist/index.node.js 130.67 KB (0%) 2.7 s (0%) 476 ms (-11.28% 🔽) 3.1 s
packages/pyroscope-flamegraph/dist/index.css 7.97 KB (0%) 160 ms (0%) 0 ms (+100% 🔺) 160 ms

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 66.34% // Head: 66.34% // No change to project coverage 👍

Coverage data is based on head (1a7b0d0) compared to base (3951bc2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1784   +/-   ##
=======================================
  Coverage   66.34%   66.34%           
=======================================
  Files         170      170           
  Lines        5551     5551           
  Branches     1252     1252           
=======================================
  Hits         3682     3682           
  Misses       1860     1860           
  Partials        9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pavelpashkovsky
Copy link
Contributor Author

/create-server

@pavelpashkovsky pavelpashkovsky requested a review from eh-am December 1, 2022 14:38
@eh-am eh-am merged commit fb4fee8 into main Dec 1, 2022
@eh-am eh-am deleted the fix-loading-tags branch December 1, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants