Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp | flamegraph): toolbar overlaps annotation #1785

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

pavelpashkovsky
Copy link
Contributor

@pavelpashkovsky pavelpashkovsky commented Dec 2, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 501.87 KB (0%) 10.1 s (0%) 3.5 s (+4.95% 🔺) 13.5 s
webapp/public/assets/app.css 19.69 KB (-0.01% 🔽) 394 ms (-0.01% 🔽) 0 ms (+100% 🔺) 394 ms
webapp/public/assets/styles.css 9.58 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 129.99 KB (0%) 2.6 s (0%) 1.8 s (+71.42% 🔺) 4.4 s
packages/pyroscope-flamegraph/dist/index.node.js 130.72 KB (0%) 2.7 s (0%) 647 ms (+39.65% 🔺) 3.3 s
packages/pyroscope-flamegraph/dist/index.css 7.97 KB (-0.02% 🔽) 160 ms (-0.02% 🔽) 0 ms (+100% 🔺) 160 ms

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 66.35% // Head: 66.35% // No change to project coverage 👍

Coverage data is based on head (8577106) compared to base (c889352).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1785   +/-   ##
=======================================
  Coverage   66.35%   66.35%           
=======================================
  Files         170      170           
  Lines        5554     5554           
  Branches     1252     1252           
=======================================
  Hits         3685     3685           
  Misses       1860     1860           
  Partials        9        9           
Impacted Files Coverage Δ
...kages/pyroscope-flamegraph/src/Toolbar.module.scss 61.54% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pavelpashkovsky
Copy link
Contributor Author

I fixed this issue by removing z-index from Toolbar styles. My testing showed that it didn't cause any problems. @eh-am, do you have any reason to have z-index for flamegraph's Toolbar ? bc I could forget about some edge case why we need setting z-index..

@pavelpashkovsky
Copy link
Contributor Author

/create-server

@Ivanikitin Ivanikitin added the frontend Mostly JS code label Dec 2, 2022
@eh-am
Copy link
Collaborator

eh-am commented Dec 2, 2022

It was introduced here #1754 by @dogfrogfog
So @dogfrogfog, can we remove that z-index?

@dogfrogfog
Copy link
Contributor

i think this can be removed

@eh-am eh-am merged commit 24722d2 into main Dec 2, 2022
@eh-am eh-am deleted the annotation-toolbar-overlap branch December 2, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Mostly JS code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants