Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): Timeline ticks overlapping #1786

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix(webapp): Timeline ticks overlapping #1786

merged 1 commit into from
Dec 2, 2022

Conversation

pavelpashkovsky
Copy link
Contributor

@pavelpashkovsky pavelpashkovsky commented Dec 2, 2022

Brief

Changes

  • added minTickSize option for timelines.
Monosnap.screencast.2022-12-02.16-01-17.mp4

DEMO: https://pr-1786.pyroscope.io/

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 501.94 KB (+0.01% 🔺) 10.1 s (+0.01% 🔺) 3.2 s (-20.48% 🔽) 13.2 s
webapp/public/assets/app.css 19.69 KB (0%) 394 ms (0%) 0 ms (+100% 🔺) 394 ms
webapp/public/assets/styles.css 9.58 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 129.99 KB (0%) 2.6 s (0%) 861 ms (-21.95% 🔽) 3.5 s
packages/pyroscope-flamegraph/dist/index.node.js 130.72 KB (0%) 2.7 s (0%) 371 ms (-51.16% 🔽) 3 s
packages/pyroscope-flamegraph/dist/index.css 7.97 KB (0%) 160 ms (0%) 0 ms (+100% 🔺) 160 ms

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 66.47% // Head: 66.47% // No change to project coverage 👍

Coverage data is based on head (d9d19b3) compared to base (9f0bf39).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1786   +/-   ##
=======================================
  Coverage   66.47%   66.47%           
=======================================
  Files         172      172           
  Lines        5594     5594           
  Branches     1260     1260           
=======================================
  Hits         3718     3718           
  Misses       1867     1867           
  Partials        9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pavelpashkovsky
Copy link
Contributor Author

/create-server

@pavelpashkovsky pavelpashkovsky requested a review from eh-am December 2, 2022 14:10
@eh-am eh-am merged commit 1a6b52d into main Dec 2, 2022
@eh-am eh-am deleted the fix-timeline-ticks branch December 2, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestamps in timeline are overlapping
2 participants