Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webapp): sync crosshair in different timelines #1813

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Jan 18, 2023

Kapture.2023-01-18.at.14.15.25.mp4

Closes #1805

Review server: https://pr-1813.pyroscope.io/

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 502.94 KB (+0.07% 🔺) 10.1 s (+0.07% 🔺) 4.4 s (-10.6% 🔽) 14.4 s
webapp/public/assets/app.css 19.75 KB (0%) 396 ms (0%) 0 ms (+100% 🔺) 396 ms
webapp/public/assets/styles.css 9.58 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 130.49 KB (0%) 2.7 s (0%) 1.6 s (-11.39% 🔽) 4.2 s
packages/pyroscope-flamegraph/dist/index.node.js 131.23 KB (0%) 2.7 s (0%) 771 ms (+71.53% 🔺) 3.4 s
packages/pyroscope-flamegraph/dist/index.css 7.99 KB (0%) 160 ms (0%) 0 ms (+100% 🔺) 160 ms

@eh-am
Copy link
Collaborator Author

eh-am commented Jan 18, 2023

/create-server

@eh-am eh-am requested a review from korniltsev January 18, 2023 14:16
@eh-am eh-am marked this pull request as ready for review January 18, 2023 14:24
Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely dont understand how this all works but if this works it looks good to me

@eh-am
Copy link
Collaborator Author

eh-am commented Jan 18, 2023

lmao all good as long as functionality is what you had in mind :)

@eh-am eh-am merged commit e8f14bd into main Jan 18, 2023
@eh-am eh-am deleted the feat/sync-timelines-crosshair branch January 18, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a shared crosshair to timelines
2 participants