Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code line for console log #188

Closed
alonlong opened this issue May 16, 2021 · 1 comment
Closed

Add code line for console log #188

alonlong opened this issue May 16, 2021 · 1 comment
Labels
backend Mostly go code enhancement New feature or request 🛠 tech-debt

Comments

@alonlong
Copy link
Contributor

now there is no code line information when printing logs, as it's useful for developers to fix issues, also when users feedback question about pyroscope, code line will be very useful~ please consider adding the code line for logs
@alonlong alonlong changed the title add code line for console log Add code line for console log May 16, 2021
@petethepig petethepig added backend Mostly go code enhancement New feature or request 🛠 tech-debt labels May 17, 2021
alonlong added a commit that referenced this issue May 25, 2021
@alonlong
fix the issue #188, add the file name and code line to logrus log
76e1539
petethepig added a commit that referenced this issue May 25, 2021
@alonlong @petethepig
fix the issue #188: add the file name and code line (#214)
63e622f 
* fix the issue #188, add the file name and code line to logrus log

Changes time format to 2021-05-25T15:54:00.033794. I think this format makes the most sense because it's both
* human-readable
* machine-readable (this is RFC3339 with microseconds)
* relatively popular
* a-z sortable
* less ambiguous when it comes to month/day vs day/month conventions
* has good enough precision for our use-case but not too much

Co-authored-by: alonlong <alonlong@163.com>
Co-authored-by: Dmitry Filimonov <dmitry@pyroscope.io>
@petethepig
Copy link
Member

This was done in #214

korniltsev pushed a commit that referenced this issue Jul 18, 2023
@simonswine
Merge pull request #188 from grafana/20220901_unify-iterators
9154e4c 
Unify iterators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Mostly go code enhancement New feature or request 🛠 tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petethepig @alonlong