Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve tooltip rendering #266

Merged
merged 5 commits into from
Jul 6, 2021
Merged

improve tooltip rendering #266

merged 5 commits into from
Jul 6, 2021

Conversation

Loggy
Copy link
Contributor

@Loggy Loggy commented Jun 28, 2021

  • moved some values computing into RenderCanvas
  • rewrite tooltip positioning from absolute top-left values to transform CSS property.

There's still a render lag. It's not so long but still visible. As the next step, I can put tooltip rendering inside canvas

@Loggy Loggy added enhancement New feature or request frontend Mostly JS code labels Jun 28, 2021
@Loggy Loggy linked an issue Jun 28, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #266 (8c21177) into main (d94dc82) will decrease coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   54.58%   53.77%   -0.81%     
==========================================
  Files          89       89              
  Lines        3637     3638       +1     
==========================================
- Hits         1985     1956      -29     
- Misses       1452     1482      +30     
  Partials      200      200              
Impacted Files Coverage Δ
pkg/server/controller.go 30.91% <0.00%> (-24.13%) ⬇️
pkg/agent/session.go 63.94% <0.00%> (-2.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d94dc82...8c21177. Read the comment docs.

@petethepig petethepig changed the title improve toooltip rendering improve tooltip rendering Jun 29, 2021
@petethepig
Copy link
Member

@Loggy I think I made it even faster by skipping react virtual dom stuff. What do you think about this solution?

@Loggy
Copy link
Contributor Author

Loggy commented Jul 4, 2021

Works really better) But it reveals that state is pretty huge and needs optimization as we can't move things out of state every time to improve rendering performance))

But in this case, I think it fits the goal)

@petethepig
Copy link
Member

Alright, let's merge this for now and next time we touch that part we can split it.

@petethepig petethepig merged commit 53ce5f8 into main Jul 6, 2021
@petethepig petethepig deleted the enchancment/tooltip_rendering branch July 6, 2021 01:46
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
…-disable-by-default

Disable auth by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Mostly JS code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix slow tooltip rendering on mouseover
2 participants