Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http and info metrics #347

Merged
merged 7 commits into from
Aug 24, 2021
Merged

Http and info metrics #347

merged 7 commits into from
Aug 24, 2021

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Aug 23, 2021

screencapture-localhost-3000-d-tsWRL6ReZQkirFirmyvnWX1akHXJeHT8I8emjGJo-pyroscope-server-2021-08-23-18_06_44

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #347 (80d736a) into main (c566451) will decrease coverage by 0.08%.
The diff coverage is 56.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   54.40%   54.32%   -0.07%     
==========================================
  Files         102      102              
  Lines        4986     5013      +27     
==========================================
+ Hits         2712     2723      +11     
- Misses       2025     2041      +16     
  Partials      249      249              
Impacted Files Coverage Δ
pkg/build/build.go 2.95% <0.00%> (-0.76%) ⬇️
pkg/cli/server.go 7.90% <0.00%> (ø)
pkg/util/debug/reporter.go 0.00% <0.00%> (ø)
pkg/server/controller.go 35.13% <100.00%> (+3.33%) ⬆️
pkg/server/http.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ee1b1...80d736a. Read the comment docs.

@eh-am
Copy link
Collaborator Author

eh-am commented Aug 24, 2021

exposing the following fields

pyroscope_build_info{GOARCH="amd64",GOOS="linux",revision="fb579a0e",time="2021-08-24T15:01:13Z",use_embedded_assets="false",version="v0.0.37"} 1

pyroscope_build_info

@petethepig petethepig merged commit 7a7d2ea into grafana:main Aug 24, 2021
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants