Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests (cypress) #356

Closed
petethepig opened this issue Aug 26, 2021 · 1 comment
Closed

Add e2e tests (cypress) #356

petethepig opened this issue Aug 26, 2021 · 1 comment
Assignees
@eh-am
Labels
frontend Mostly JS code tests

Comments

@petethepig
Copy link
Member

petethepig commented Aug 26, 2021 •
edited
Loading

This is a placeholder for e2e tests
@eh-am
Copy link
Collaborator

eh-am commented Aug 27, 2021 •
edited
Loading

Added the boilerplate in #359
More tests are welcome.

Few tests I have in mind:

  • test table/both/flamegraph buttons are working
  • test time selection is working
  • test app change (the drop-down at the top) is working
  • test sorting is working
  • test that data is being renderer in the table and in the flamegraph
    • this would probably require visual testing against a golden image
    • then we also validate that clicking on a bar is working too (the drill down effect)

@petethepig petethepig added frontend Mostly JS code tests labels Aug 30, 2021
@ruslanpascoal2 ruslanpascoal2 mentioned this issue Sep 4, 2021
Merged
petethepig pushed a commit that referenced this issue Sep 6, 2021
@ruslanpascoal2
tests for table/both/flamegraph buttons (issue #356) (#375)
75b0357 
* add tests for table/both/flamegraph buttons

* remove it.only fix

* fix jest snapshots

* jest snapshot fix
@ruslanpascoal2 ruslanpascoal2 mentioned this issue Sep 9, 2021
Merged
petethepig pushed a commit that referenced this issue Sep 16, 2021
@ruslanpascoal2
tests for app change dropdown (issue #356) (#386)
2332075 
* add tests for table/both/flamegraph buttons

* remove it.only fix

* fix jest snapshots

* jest snapshot fix

* add tests for app selector

* add cy.wait on requests

* improving fixtures

* lint fix

* lint fix

* fix tests

* remove duplicate prop

* fix tests
@ruslanpascoal2 ruslanpascoal2 mentioned this issue Sep 21, 2021
Merged
petethepig pushed a commit that referenced this issue Sep 22, 2021
@ruslanpascoal2 @eh-am
tests for table sorting (issue #356) (#407)
9bdabca 
* add tests for table/both/flamegraph buttons

* remove it.only fix

* fix jest snapshots

* jest snapshot fix

* add tests for app selector

* add cy.wait on requests

* improving fixtures

* lint fix

* lint fix

* fix tests

* remove duplicate prop

* fix tests

* frontend: fix sort function

as the updateSortBy function was called indirectly
the 'this' was being undefined

there are couple different ways of solving this issue

1. binding (in the constructor), such as
this.updateSortBy = this.updateSortBy.bind(this)

2. declaring updateSortBy as an arrow function,
since arrow functions don't bind the 'this',
we end up using the class one

i've preferred to use 2) since we are already using it

* tests for table sorting

Co-authored-by: eduardo <eduardoaleixomartins@gmail.com>
@abeaumont abeaumont mentioned this issue Feb 4, 2022
Closed
@eh-am eh-am closed this as completed Nov 24, 2022
korniltsev pushed a commit that referenced this issue Jul 18, 2023
@cyriltovena @simonswine
Adds anonymous statistics reporting (#356)
7de0c86 
* Adds anonymous statistics reporting

* Update go mod

* Review feedback

Co-authored-by: Christian Simon <simon@swine.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eh-am eh-am

Labels
frontend Mostly JS code tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petethepig @eh-am