Enhancement/split flamegraphrenderer

[Loggy]

No description provided.

[codecov]

Codecov Report

Merging #360 (133b35b) into main (75b0357) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   51.02%   51.07%   +0.05%     
==========================================
  Files         117      117              
  Lines        5251     5258       +7     
==========================================
+ Hits         2679     2685       +6     
+ Misses       2313     2310       -3     
- Partials      259      263       +4     

Impacted Files	Coverage Δ
pkg/exec/cli_unix.go	9.44% <0.00%> (-1.88%)	⬇️
pkg/exec/cli.go	46.48% <0.00%> (-0.70%)	⬇️
pkg/server/controller.go	45.74% <0.00%> (-0.12%)	⬇️
pkg/server/handler.go	2.55% <0.00%> (+1.92%)	⬆️
pkg/agent/upstream/remote/remote.go	65.22% <0.00%> (+2.90%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38d6714...133b35b. Read the comment docs.

[Rperry2174]

Thanks for the updates @Loggy ! We recently added Cyprus testing and it looks like one is failing.

1. Can you make sure this branch is up to date with master?
2. Can you also add a test that checks for the following scenario: when a new app is selected in the dropdown that the flamegraph renderer updates?

You can see more details (and even videos) here:

Also @eh-am might be able to answer questions about Cyprus in general if you have any

[Rperry2174]

Hey @Loggy I think something might have gone wrong with the rebase (or maybe it needs to be rebased still)

Here is our staging version: https://demo-dev.pyroscope.io/comparison?name=cart.service.dotnet.cpu%7B%7D&from=1630441060&leftFrom=1630441133&leftUntil=1630441428&rightFrom=1630441437&rightUntil=1630441770&until=1630441960

and here is your PR version
https://pr-360.pyroscope.cloud/comparison-diff?name=cart.service.dotnet.cpu%7B%7D&from=1630441060&leftFrom=1630441133&leftUntil=1630441428&rightFrom=1630441437&rightUntil=1630441770&until=1630441960

(btw you can find a link to your PR server shown above here):

H

[Rperry2174]

Also make sure to check the Diff view as well:

Demo App: https://demo-dev.pyroscope.io/comparison-diff

This PR: https://pr-360.pyroscope.cloud/comparison-diff

[Rperry2174]

Hey @Loggy noticed a bug where the tooltip from the left flamegraph goes behind the right flamegraph:

[Rperry2174]

Also there is a random dot that appears on page load. I think this is related to the tooltip because it disappears when we use the tooltip, but I'm not sure:

[petethepig]

jenkins, create a review app server please