reduces bundle size #362
Merged
reduces bundle size #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petethepig
commented
Aug 31, 2021
| @@ -23,7 +22,7 @@ import { | |||
| import { parseLabels, encodeLabels } from "../util/key"; | |||
|
|
|||
| const enhancer = composeWithDevTools( | |||
| applyMiddleware(thunkMiddleware, promiseMiddleware) | |||
| applyMiddleware(thunkMiddleware) | |||
There was a problem hiding this comment.
looks like we're not using promiseMiddleware
Codecov Report
@@ Coverage Diff @@
## main #362 +/- ##
=======================================
Coverage 51.61% 51.61%
=======================================
Files 104 104
Lines 5007 5007
=======================================
Hits 2584 2584
Misses 2175 2175
Partials 248 248 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: 546.1 KB
After: 471.44 KB
^ these are gzipped production numbers from webpack bundle analyzer
This is what it currently looks like:
Addresses #362