Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for table/both/flamegraph buttons (issue #356) #375

Merged
merged 4 commits into from
Sep 6, 2021

Conversation

ruslanpascoal2
Copy link
Contributor

@ruslanpascoal2 ruslanpascoal2 commented Sep 4, 2021

#356

This is only the first item from the issue, just to dig my toe in the water.

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 5, 2021

Codecov Report

Merging #375 (736e438) into main (e14038f) will increase coverage by 0.80%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   50.26%   51.06%   +0.80%     
==========================================
  Files         117      117              
  Lines        5239     5251      +12     
==========================================
+ Hits         2633     2681      +48     
+ Misses       2355     2311      -44     
- Partials      251      259       +8     
Impacted Files Coverage Δ
pkg/server/handler.go 0.64% <0.00%> (-<0.01%) ⬇️
pkg/cli/flags.go 66.07% <0.00%> (+2.72%) ⬆️
pkg/cli/command.go 56.76% <0.00%> (+56.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f491e...736e438. Read the comment docs.

@eh-am
Copy link
Collaborator

eh-am commented Sep 5, 2021

Thank you for your contribution, @ruslanpascoal2!

It seems a jest snapshot is failing, can you update it please?

@ruslanpascoal2
Copy link
Contributor Author

Thank you for your contribution, @ruslanpascoal2!

It seems a jest snapshot is failing, can you update it please?

Fixed it

@petethepig petethepig merged commit 75b0357 into grafana:main Sep 6, 2021
@Rperry2174
Copy link
Contributor

Thanks for the tests @ruslanpascoal2 !!!

korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants