Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate a random prefix for server bench pr docker-compose #392

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Sep 14, 2021

the reasoning here is that we may want to run multiple jobs
at the same time with different profiles (different parameters)

that requires a custom prefix, since docker-compose assumes
the name of the directory

also remove the ports binding, which generally aren't needed
unless one wants to run locally, which in that case can be added manually

the reasoning here is that we may want to run multiple jobs
at the same time with different profiles (different parameters)

that requires a custom prefix, since docker-compose assumes
the name of the directory
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #392 (cb84165) into main (0403cee) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   49.52%   49.56%   +0.04%     
==========================================
  Files         121      121              
  Lines        5499     5499              
==========================================
+ Hits         2723     2725       +2     
+ Misses       2508     2506       -2     
  Partials      268      268              
Impacted Files Coverage Δ
pkg/agent/upstream/remote/remote.go 65.22% <0.00%> (+2.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0403cee...cb84165. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

Benchmark Result

main pr diff threshold
throughput 154.76 154.16 -0.59 (-0.38%) 5%
total items processed 131208.00 131459.00 251.00 (0.19%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Benchmark Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against c554dac

Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense, looks good!

@petethepig
Copy link
Member

@eh-am I don't know if it's fully finished, feel free to merge when you want to

@eh-am eh-am merged commit 8993204 into main Sep 14, 2021
@eh-am eh-am deleted the add-prefix branch September 14, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants