Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise ingestion allocations #411

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Optimise ingestion allocations #411

merged 1 commit into from
Sep 23, 2021

Conversation

kolesnikovae
Copy link
Collaborator

No description provided.

@kolesnikovae kolesnikovae self-assigned this Sep 22, 2021
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #411 (f15361a) into main (9bdabca) will increase coverage by 0.19%.
The diff coverage is 78.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   50.66%   50.85%   +0.19%     
==========================================
  Files         125      125              
  Lines        5664     5710      +46     
==========================================
+ Hits         2869     2903      +34     
- Misses       2519     2528       +9     
- Partials      276      279       +3     
Impacted Files Coverage Δ
pkg/convert/parser.go 61.37% <0.00%> (-1.42%) ⬇️
pkg/server/controller.go 45.74% <ø> (ø)
pkg/storage/tree/tree.go 82.48% <0.00%> (-0.85%) ⬇️
pkg/structs/transporttrie/serialize.go 65.17% <76.20%> (+9.85%) ⬆️
pkg/server/ingest.go 61.73% <100.00%> (+3.51%) ⬆️
pkg/agent/upstream/remote/remote.go 62.32% <0.00%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feac8b5...f15361a. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 157.62 157.82 0.19 (0.12%) 5%
total items processed 132221.00 132077.00 -144.00 (-0.11%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against 545be54

@kolesnikovae kolesnikovae marked this pull request as ready for review September 23, 2021 17:00
Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, merging

@petethepig petethepig merged commit ec880c5 into main Sep 23, 2021
@petethepig petethepig deleted the ingestion-optimisation branch September 23, 2021 20:26
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Fixes goreleaser version in binary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants