Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reset view #414

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Fix reset view #414

merged 3 commits into from
Sep 23, 2021

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Sep 22, 2021

The "Reset View" button wasn't working properly. This PR fixes it

image

Also added a simple test that clicks on the flamegraph, so maybe we could move that to a bigger test that tests the drill effect and whatnot.

@ruslanpascoal2 I've created a new fixture based on real profiling data (the go example), I think it's best to use this one from now on, since it makes testing easier since you have real, consistent data to base on (for example the previous render.json file produces a broken flamegraph).

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #414 (df4e169) into main (0b17e11) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   50.62%   50.62%           
=======================================
  Files         125      125           
  Lines        5664     5664           
=======================================
  Hits         2867     2867           
  Misses       2521     2521           
  Partials      276      276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b17e11...df4e169. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Sep 22, 2021

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 155.23 155.18 -0.05 (-0.03%) 5%
total items processed 131600.00 131606.00 6.00 (0.00%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against 2f78541

@ruslanpascoal2
Copy link
Contributor

ruslanpascoal2 commented Sep 22, 2021

Ok, I'll use it, thanks!

@eh-am eh-am merged commit f8da10f into main Sep 23, 2021
@eh-am eh-am deleted the fix-reset-view branch September 23, 2021 15:48
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants