-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reset view #414
Merged
Merged
Fix reset view #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
=======================================
Coverage 50.62% 50.62%
=======================================
Files 125 125
Lines 5664 5664
=======================================
Hits 2867 2867
Misses 2521 2521
Partials 276 276 Continue to review full report at Codecov.
|
eh-am
force-pushed
the
fix-reset-view
branch
from
September 22, 2021 19:27
48584b4
to
c84da25
Compare
ParametersDetails
Result
Details
Screenshots |
Ok, I'll use it, thanks! |
eh-am
force-pushed
the
fix-reset-view
branch
from
September 22, 2021 20:05
c84da25
to
df4e169
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Reset View" button wasn't working properly. This PR fixes it
Also added a simple test that clicks on the flamegraph, so maybe we could move that to a bigger test that tests the drill effect and whatnot.
@ruslanpascoal2 I've created a new fixture based on real profiling data (the go example), I think it's best to use this one from now on, since it makes testing easier since you have real, consistent data to base on (for example the previous
render.json
file produces a broken flamegraph).