Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Multi-day load tests fail for dmsp ivm f18 #99

Open
jklenzing opened this issue Feb 26, 2024 · 2 comments
Open

MAINT: Multi-day load tests fail for dmsp ivm f18 #99

jklenzing opened this issue Feb 26, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@jklenzing
Copy link
Member

Description

The DMSP ivm f18 data is not passing the pysat 3.2.0 RC tests for multi-day load.

To Reproduce this bug:

See log in https://github.com/pysat/pysatMadrigal/actions/runs/8053868866/job/21997186424

Test configuration

  • OS: all OS tested in GitHub Actions
  • Version python 3.10

Additional context

tentative solution is to use the _new_tests flag to skip for this instrument for both RCs, then fix in the next bug release.

@jklenzing jklenzing added the bug Something isn't working label Feb 26, 2024
@aburrell
Copy link
Member

Also:

inst_dict = {'inst_id': '', 'inst_module': <module 'pysatMadrigal.instruments.jro_isr' from '/home/runner/work/pysatMadrigal/pysat...ments/jro_isr.py'>, 'tag': 'drifts', 'user_info': {'password': 'pysat.developers@gmail.com', 'user': 'pysat+CI_tests'}}

    @pytest.mark.second
    @pytest.mark.load_options
    @pytest.mark.new_tests
    def test_load_multiple_days(self, inst_dict):

@aburrell
Copy link
Member

aburrell commented Mar 4, 2024

There are several other instances where flags were added with links to this issue as a TODO.

@aburrell aburrell added this to the v0.3.0 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants