Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: update demo codes #29

Closed
jklenzing opened this issue Dec 22, 2021 · 1 comment · Fixed by #30
Closed

DOC: update demo codes #29

jklenzing opened this issue Dec 22, 2021 · 1 comment · Fixed by #30
Labels
documentation Improvements or additions to documentation
Milestone
0.2.0 release

Comments

@jklenzing
Copy link
Member

jklenzing commented Dec 22, 2021 •
edited
Loading

Describe the bug

  • Demo codes currently use old custom.attach rather than custom_attach.
  • Add docstrings to functions in demo codes to assist flow for users
  • Scrub for modern style

To Reproduce
Try to run a demo with pysat 3.0+

Expected behavior
Code should match standards for first time users
@jklenzing jklenzing added the documentation Improvements or additions to documentation label Dec 22, 2021
@jklenzing jklenzing added this to the 0.2.0 release milestone Dec 22, 2021
@rstoneback rstoneback linked a pull request Feb 24, 2022 that will close this issue
Rcv0 2 0 #30
Merged
18 tasks
@rstoneback rstoneback mentioned this issue Feb 25, 2022
Merged
18 tasks
@jklenzing
Copy link
Member Author

jklenzing commented Aug 4, 2022 •
edited
Loading

This has been solved. premature

@jklenzing jklenzing reopened this Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.2.0 release
Development

Successfully merging a pull request may close this issue.

Rcv0 2 0 pysat/pysatSeasons
1 participant
@jklenzing