Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualenv_name optoin doesn't make effect #458

Open
ghost opened this issue Feb 27, 2019 · 0 comments
Open

virtualenv_name optoin doesn't make effect #458

ghost opened this issue Feb 27, 2019 · 0 comments

Comments

@ghost
Copy link

ghost commented Feb 27, 2019

Documentation says

If you would like to share a single virtualenv across topologies, you can set "virtualenv_name" in config.json which overrides the default behaviour of using the topology name for virtualenv.

I used it in conjunction with install_virtualenv set to false in order to use an existing virtualenv.
But unfortunately, it doesn't work - I inspected the worker's logs and found that it still used the topology name as the virtualenv name. I inspected the source of Streamparse and found that the virtualenv_name is not included into VIRTUALENV_OPTIONS in streamparse/cli/common.py and therefore it's not returned by resolve_options. The code calling resolve_options in streamparse/cli/submit.py assumes that virtualenv_name might be in the resulting dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants