Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node/Link Inheritance Consistency #501

Open
bemcdonnell opened this issue Dec 12, 2023 · 0 comments
Open

Node/Link Inheritance Consistency #501

bemcdonnell opened this issue Dec 12, 2023 · 0 comments
Assignees
@bemcdonnell
Labels
type:task
Milestone
pyswmm-v2.1

Comments

@bemcdonnell
Copy link
Member

For PySWMM-v2 there are several properties/methods inside the Node and Link classes that only apply to specific parts. These properties and methods should only be introduced to the Node and Link objects through proper inheritance. PySWMM-v1.6 should introduce warnings and pyswmm-v2 should see the actual structural changes to nodes.py and links.py modules.
@bemcdonnell bemcdonnell added this to the pyswmm-v2.0 milestone Dec 12, 2023
@bemcdonnell bemcdonnell self-assigned this Dec 12, 2023
@bemcdonnell bemcdonnell modified the milestones: pyswmm-v2.0, pyswmm-v2.1 Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bemcdonnell bemcdonnell

Labels
type:task
Projects
None yet
Milestone
pyswmm-v2.1
Development

No branches or pull requests
1 participant
@bemcdonnell