Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better document exception handling #123

Closed
notestaff opened this issue Mar 1, 2018 · 1 comment
Closed

better document exception handling #123

notestaff opened this issue Mar 1, 2018 · 1 comment

Comments

@notestaff
Copy link

Docs of _Result.getresult() should make more clear that, if one of the hook impls threw an exception, the getresult() call will throw that exception. In general, maybe add a dedicated docs section explaining exactly what happens when hooks (normal ones or hook wrappers) throw exceptions.

@nicoddemus
Copy link
Member

Thanks for the report @notestaff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants