Fixes for typed pluggy #11353
Merged
Fixes for typed pluggy #11353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
commented
Aug 26, 2023
| # Collect unmarked hooks as long as they have the `pytest_' prefix. | ||
| return _get_legacy_hook_marks( | ||
| return _get_legacy_hook_marks( # type: ignore[return-value] |
There was a problem hiding this comment.
This can be improved, but the legacy hook stuff is going to be removed in pytest 8.1 so I didn't bother.
Since version 1.3 pluggy added typing, which requires some fixes to please mypy.
bluetech
force-pushed
the
pluggy-typing
branch
from
4cf45ab
to
77f7f59
Compare
|
Merging to fix the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 1.3 pluggy added typing, which requires some fixes to please mypy.
Pending release of pluggy 1.3
I intend to backport this to 7.4.x but without bumping the pluggy requirement so will be a little different.