Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on test arguments with default values? #12693

Open
The-Compiler opened this issue Aug 6, 2024 · 2 comments · May be fixed by #13044
Open

Warn on test arguments with default values? #12693

The-Compiler opened this issue Aug 6, 2024 · 2 comments · May be fixed by #13044
Labels
type: enhancement new feature or API change, should be merged into features branch

Comments

@The-Compiler
Copy link
Member

As someone pointed out in my pytest training, pytest currently silently accepts:

def test_fixt(fixt=42):
    ...

with fixt obviously being 42 in the test function no matter if such a fixture was ever defined or not.

There doesn't really seem any valid reason to do this kind of thing, yet some ideas float around how default argument like this could be used in the future with either test functions (e.g. #3834) or with fixture functions (e.g. #8109).

To avoid accidental usage and possibly allow for different usage in the future, should we maybe add a warning if default argument values are used like this?

@RonnyPfannschmidt
Copy link
Member

We should also propose this as a potential ruff rule

@huangbenny
Copy link

I can take this as my first issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement new feature or API change, should be merged into features branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants