-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move python api code to own file #2489
Move python api code to own file #2489
Conversation
this separates exposed normal api from collection elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should call the new file just api.py
?
Also what's the intent for moving those classes? |
@nicoddemus cutting down the file sizes before introducing |
cce9c99
to
f8b2277
Compare
OK, was just wondering. |
wrt the filename - api.py seems a bit short and non-saying - same for python api i do wonder about splitting logical bits into more files |
but yeah, this can be merged ^^ |
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs:
$issue_id.$type
for example (588.bug)removal
,feature
,bugfix
,vendor
,doc
ortrivial
bugfix
,vendor
,doc
ortrivial
fixes, targetmaster
; for removals or features targetfeatures
;