-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup #3015
Code cleanup #3015
Conversation
855b4af
to
db10629
Compare
a73fbde
to
c278b47
Compare
c278b47
to
b05bdf0
Compare
b05bdf0
to
73bc6ba
Compare
# mixed module and filenames: | ||
os.chdir('world') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code<> commend swap looks unintended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I thought it seemed correct - there are two pytest runs here and for each we set up a suitable cwd folder
easy enough to revert if you dislike it, I'm just curious as to what the intended meaning here was then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, in full context it looks correct after all - before this change the lines where directly matching the code in question, but now its indeed marking the test sections instead
overall good work on many many little details 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup, thanks @jurko-gospodnetic!
Code cleanup done while working on another pull request and extracted here so it would not cloud up the original pull request.