pytest.approx gives wrong result when compared with numpy types

[nosarthur]

In [18]: import pytest, numpy

In [19]: pytest.__version__
Out[19]: '3.5.1'

In [20]: numpy.__version__
Out[20]: '1.12.0'

In [21]: a = numpy.float64(3e-9)

In [22]: a == pytest.approx(0, abs=1e-7)
Out[22]: False

In [23]: float(a) == pytest.approx(0, abs=1e-7)
Out[23]: True

With pytest version 3.4.1, numpy 1.12.0, pytest.approx has the correct behavior

[mghicho]

Here is what I got, my numpy is 1.14.2 though.

Python 3.6.5 (v3.6.5:f59c0932b4, Mar 28 2018, 17:00:18) [MSC v.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import pytest, numpy
>>> pytest.__version__
'3.5.1'
>>> numpy.__version__
'1.14.2'
>>> a = numpy.float64(3e-9)
>>> a == pytest.approx(0, abs=1e-7)
True
>>> float(a) == pytest.approx(0, abs=1e-7)
True
>>>

[nosarthur]

I tried pytest 3.5.1 and numpy 1.14.0. The pytest.approx behaves correctly.

[nicoddemus]

Seems related to this feature which was introduced in 3.5.0:

pytest.approx now accepts comparing a numpy array with a scalar. (#3312)

So I believe we can close this @nosarthur?

[nosarthur]

Sure, thanks