Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate arguments of parametrize mark #3645

Open
RonnyPfannschmidt opened this issue Jun 30, 2018 · 2 comments
Open

validate arguments of parametrize mark #3645

RonnyPfannschmidt opened this issue Jun 30, 2018 · 2 comments
Labels
topic: parametrize related to @pytest.mark.parametrize type: enhancement new feature or API change, should be merged into features branch

Comments

@RonnyPfannschmidt
Copy link
Member

followup to #3644

the error messages in minor mistakes are quite a pain and at a distance, we could do much better there by invoking a function that has the expected signature and/or checking the arguments against a signature

@pytestbot
Copy link
Contributor

GitMate.io thinks possibly related issues are #2383 (AssertionError with wrong number of parametrize arguments), #1111 (pytest.mark.parametrize fails with lambdas), #213 (Issue with numpy arrays and pytest.mark.parametrize), #518 (parametrize: allow ellipsis to avoid repeating argument list?), and #2176 (parametrize ignores marks if parameters are symbols).

@RonnyPfannschmidt RonnyPfannschmidt added type: enhancement new feature or API change, should be merged into features branch status: help wanted developers would like help from experts on this topic type: feature-branch new feature or API change, should be merged into features branch good first issue easy issue that is friendly to new contributor labels Jun 30, 2018
@pytestbot pytestbot removed good first issue easy issue that is friendly to new contributor status: help wanted developers would like help from experts on this topic type: feature-branch new feature or API change, should be merged into features branch labels Jun 30, 2018
@Zac-HD
Copy link
Member

Zac-HD commented Oct 19, 2018

#3674 suggests that this check should be implemented as the test failing, rather than an error at collection time.

@Zac-HD Zac-HD added the topic: parametrize related to @pytest.mark.parametrize label Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: parametrize related to @pytest.mark.parametrize type: enhancement new feature or API change, should be merged into features branch
Projects
None yet
Development

No branches or pull requests

3 participants