Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve isosurface computation #228

Open
jbweston opened this issue Nov 20, 2019 · 4 comments
Open

improve isosurface computation #228

jbweston opened this issue Nov 20, 2019 · 4 comments

Comments

@jbweston
Copy link
Contributor

When computing the isosurface, when 4 simplex edges crosses the isosurface, we add 2 triangles to the isosurface triangulation.

Right now we add these arbitrarily (in these 3 lines) but we should add them so that the curvature is minimized.

The current state of affairs produces plots like this:

K3D-1574269258138

Note how the isosurface on the right hand side of the figure is not smooth.

@oroszl
Copy link

oroszl commented Nov 23, 2019

Hey @jbweston can you put up the example notebook for producing the above plot somewhere?

@jhoofwijk
Copy link
Contributor

I had though about that before, but the four points which are found are co-planar, so it doesn't matter in what way you make the triangles. The roughness comes from differences between adjacent tetrahedra.

@akhmerov
Copy link
Contributor

akhmerov commented Jan 2, 2020

@jhoofwijk thanks for the clarification, that's an excellent point.

@akhmerov
Copy link
Contributor

akhmerov commented Jan 6, 2020

OTOH the isosurface seems to have artifacts... wondering how to investigate the specific origin of those...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants