Skip to content

Reddit cog does not await revoke_access_token in cog_unload #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarkKoz opened this issue Feb 26, 2020 · 1 comment · Fixed by #785
Closed

Reddit cog does not await revoke_access_token in cog_unload #794

MarkKoz opened this issue Feb 26, 2020 · 1 comment · Fixed by #785
Labels
a: information Related to information commands: (doc, help, information, reddit, site, tags) good first issue Good for newcomers p: 2 - normal Normal Priority t: bug Something isn't working

Comments

@MarkKoz
Copy link
Member

MarkKoz commented Feb 26, 2020 •
edited
Loading

I think the fix is as simple as using create_task for it.

https://github.com/python-discord/bot/blob/master/bot/cogs/reddit.py#L47
@MarkKoz MarkKoz changed the title Reddit cog does not await revoke_access_token w Reddit cog does not await revoke_access_token in cog_unload Feb 26, 2020
@MarkKoz MarkKoz added a: information Related to information commands: (doc, help, information, reddit, site, tags) good first issue Good for newcomers p: 2 - normal Normal Priority t: bug Something isn't working labels Feb 26, 2020
@sco1
Copy link
Contributor

sco1 commented Feb 26, 2020 •
edited
Loading

This simple thing can probably be thrown in with #785, which already has another minor fix to the Reddit cog in it. It's pretty much ready to merge already.

cc @Numerlor

@Numerlor Numerlor mentioned this issue Feb 26, 2020
Merged
@shtlrs shtlrs mentioned this issue Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: information Related to information commands: (doc, help, information, reddit, site, tags) good first issue Good for newcomers p: 2 - normal Normal Priority t: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Verify channels against server and reddit OAuth2 in constants on startup. Numerlor/bot
2 participants
@MarkKoz @sco1