Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pipfile.lock #99

Closed
pydis-bot opened this issue Nov 17, 2018 · 6 comments · Fixed by #196
Closed

Update Pipfile.lock #99

pydis-bot opened this issue Nov 17, 2018 · 6 comments · Fixed by #196
Assignees
Labels
a: dependencies Related to package dependencies and management

Comments

@pydis-bot
Copy link

Originally posted by Mark:

There are several issues with our dependencies:

  1. discord.py should be added as a git URL rather than using the zip URL. This will allow it have a ref and thus be locked to a specific version of the library.
  2. The locked aiohttp (==2.2.5) and websockets (==4.0.1) versions do not satisfy the current requirements of discord.py.
  3. flake8 should be updated to 3.6.0 as it currently misses some errors that we would presumably want to catch (well, maybe W605 is a false positive). See this for all errors in the project which it is currently missing.
@pydis-bot
Copy link
Author

Comment from Mark:

changed title from Update Pip{-e-}file.lock to Update Pipfile.lock

@pydis-bot
Copy link
Author

Comment from Scragly:

Agreed. 1 and 2 were things I noticed when I first loaded the project up too, along with the fact that the discord.py package should be named discord-py in the Pipfile, not discord.

In a personal project's Pipfile, I have discord.py listed with:

discord-py = {git="https://github.com/Rapptz/discord.py.git", ref="rewrite", editable=true}

but as you stated, a commit ref will work perfectly fine:

discord-py = {git="https://github.com/Rapptz/discord.py.git", ref="860d6a9ace8248dfeec18b8b159e7b757d9f56bb", editable=true}

The editable flag should be ensured to be added, as without it, it sometimes doesn't update the package on ref change, same with the package's dependency updates.

@pydis-bot
Copy link
Author

Comment from Mark:

Just noticed that the name is currently discord and not discord-py in the Pipfile too. By the way, I think the dash is preferred over the dot, for now at least, since there is a bug with pipenv for packages with a . (or a select few other symbols) in the name.

@pydis-bot
Copy link
Author

Comment from Gareth Coles:

The package is named discord, though. It's also named that on pypi.

@pydis-bot
Copy link
Author

Comment from Mark:

No it isn't:

@pydis-bot
Copy link
Author

Comment from Gareth Coles:

Huh, weird. I thought it was.

@MarkKoz MarkKoz self-assigned this Nov 17, 2018
@MarkKoz MarkKoz added the a: dependencies Related to package dependencies and management label Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: dependencies Related to package dependencies and management
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants