Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note on readme and changelog that py2.7 support is dropped #626

Closed
kapilt opened this issue Nov 14, 2019 · 3 comments
Closed

note on readme and changelog that py2.7 support is dropped #626

kapilt opened this issue Nov 14, 2019 · 3 comments
Labels
Invalid Not a bug, PEBKAC, or an unsupported setup

Comments

@kapilt
Copy link

kapilt commented Nov 14, 2019

looks like starting with 3.1

@kapilt
Copy link
Author

kapilt commented Nov 14, 2019

just noticed this #611

the case we saw this was actually the change to use importlib_metadata which uses more_itertools which dropped 2.7 support earlier this year.

Notice:      import jsonschema
Notice:    File "/home/cloud-custodian/custodian/lib/python2.7/site-packages/jsonschema/__init__.py", line 31, in <module>
Notice:      import importlib_metadata
Notice:    File "/home/cloud-custodian/custodian/lib/python2.7/site-packages/importlib_metadata/__init__.py", line 9, in <module>
Notice:      import zipp
Notice:    File "/home/cloud-custodian/custodian/lib/python2.7/site-packages/zipp.py", line 12, in <module>
Notice:      import more_itertools
Notice:    File "/home/cloud-custodian/custodian/lib/python2.7/site-packages/more_itertools/__init__.py", line 1, in <module>
Notice:      from more_itertools.more import *  # noqa
Notice:    File "/home/cloud-custodian/custodian/lib/python2.7/site-packages/more_itertools/more.py", line 340
Notice:      def _collate(*iterables, key=lambda a: a, reverse=False):
Notice:                                 ^
Notice:  SyntaxError: invalid syntax

@kapilt
Copy link
Author

kapilt commented Nov 14, 2019

its also unclear if this project is supporting py2.7 why its not in the ci versions being tested.

@kapilt kapilt closed this as completed Nov 14, 2019
@Julian
Copy link
Member

Julian commented Nov 14, 2019

2.7 is supported, and is still tested under CI, and is passing in CI (albeit we only test under PyPy these days, given it's the only Py2.7 that will continue to be supported past December 31).

@Julian Julian added the Invalid Not a bug, PEBKAC, or an unsupported setup label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid Not a bug, PEBKAC, or an unsupported setup
Projects
None yet
Development

No branches or pull requests

2 participants