Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firefox to the Travis test matrix #60

Closed
jphalip opened this issue Jan 8, 2017 · 3 comments
Closed

Add Firefox to the Travis test matrix #60

jphalip opened this issue Jan 8, 2017 · 3 comments

Comments

@jphalip
Copy link
Collaborator

jphalip commented Jan 8, 2017

Currently we only test with PhantomJS. For more completeness, it'd be useful to add Firefox following the steps here: https://docs.travis-ci.com/user/gui-and-headless-browsers/#Using-xvfb-to-Run-Tests-That-Require-a-GUI

@cgoldberg
Copy link

+1 for adding Chrome also

@jmbowman
Copy link
Contributor

Since both Chrome and Firefox have been added to Travis, I presume this can be closed now.

@jphalip
Copy link
Collaborator Author

jphalip commented Mar 24, 2017

That's right, thanks.

@jphalip jphalip closed this as completed Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants