Skip to content

Add integration with Starlette #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sisp opened this issue Sep 25, 2022 · 3 comments · Fixed by #427
Closed

Add integration with Starlette #424

sisp opened this issue Sep 25, 2022 · 3 comments · Fixed by #427

Comments

@sisp
Copy link
Contributor

sisp commented Sep 25, 2022

Starlette is a quite popular ASGI library, in part because it's at the core of the (to me somewhat surprisingly) vastly popular FastAPI project. Since I believe in the spec-first approach (contrary to FastAPI) and in the architectural design of openapi-core, I think it would be great to add an integration with Starlette.

@p1c2u
Copy link
Collaborator

p1c2u commented Sep 25, 2022

I was thinking about it. I would go even further and try to integrate with FastAPI itself as an alternative to built-in approach.

@sisp
Copy link
Contributor Author

sisp commented Sep 25, 2022

Hm, I haven't thought about the technical details, but perhaps it's possible to have both because FastAPI is built on top of Starlette? Perhaps via a Starlette middleware like it's done for other sane web frameworks. I'm a bit sceptical about FastAPI to be honest. Starlette looks very clean and modular though.

@sisp
Copy link
Contributor Author

sisp commented Sep 29, 2022

Awesome, thanks for adding support for Starlette so quickly, @p1c2u! 🙏 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants