Skip to content

Commit b1e2f2e

Browse files
committed
Improved coverage
1 parent e90bb15 commit b1e2f2e

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

Tests/test_imagetext.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@ def test_get_length(font: ImageFont.FreeTypeFont) -> None:
3232
assert ImageText.Text("y", font).get_length() == 12
3333
assert ImageText.Text("a", font).get_length() == 12
3434

35+
text = ImageText.Text("\n", font)
36+
with pytest.raises(ValueError, match="can't measure length of multiline text"):
37+
text.get_length()
38+
3539

3640
def test_get_bbox(font: ImageFont.FreeTypeFont) -> None:
3741
assert ImageText.Text("A", font).get_bbox() == (0, 4, 12, 16)
@@ -45,13 +49,20 @@ def test_standard_embedded_color(layout_engine: ImageFont.Layout) -> None:
4549
font = ImageFont.truetype(FONT_PATH, 40, layout_engine=layout_engine)
4650
text = ImageText.Text("Hello World!", font)
4751
text.embed_color()
52+
assert text.get_length() == 288
4853

4954
im = Image.new("RGB", (300, 64), "white")
5055
draw = ImageDraw.Draw(im)
5156
draw.text((10, 10), text, "#fa6")
5257

5358
assert_image_similar_tofile(im, "Tests/images/standard_embedded.png", 3.1)
5459

60+
text = ImageText.Text("", mode="1")
61+
with pytest.raises(
62+
ValueError, match="Embedded color supported only in RGB and RGBA modes"
63+
):
64+
text.embed_color()
65+
5566

5667
@skip_unless_feature("freetype2")
5768
def test_stroke() -> None:

src/PIL/ImageText.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,5 @@ def get_bbox(
316316
max(bbox[3], bbox_line[3]),
317317
)
318318

319-
if bbox is None:
320-
return xy[0], xy[1], xy[0], xy[1]
319+
assert bbox is not None
321320
return bbox

0 commit comments

Comments
 (0)