Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1.1 release #3089

Closed
wiredfool opened this issue Apr 11, 2018 · 15 comments
Closed

5.1.1 release #3089

wiredfool opened this issue Apr 11, 2018 · 15 comments
Labels
Milestone

Comments

@wiredfool
Copy link
Member

wiredfool commented Apr 11, 2018

@wiredfool wiredfool added this to the 5.1.1 milestone Apr 11, 2018
@wiredfool
Copy link
Member Author

I'd appreciate any help on this.

@matthew-brett
Copy link
Contributor

I believe it's dangerous to build 3.7 wheels before the official release, as the binary API may change.

@homm
Copy link
Member

homm commented Apr 11, 2018

Include #3067 ?

I'm for it. Compilation problems are that can be fixed in minor updates

@paregorios
Copy link

Respectfully, from the user gallery: I'd prefer to see Pillow 5.1.1 not get held up for Python 3.7 official release, which is iirc still a couple months away. Because #3068. Thanks.

@wiredfool
Copy link
Member Author

Ok, #3067 and xcode6.4 wheels.

@hugovk
Copy link
Member

hugovk commented Apr 12, 2018

I've done the first steps of https://github.com/python-pillow/Pillow/blob/master/RELEASING.md#point-release on https://github.com/python-pillow/Pillow/tree/5.1.x:


Point Release

Released as needed for security, installation or critical bug fixes.

  • Make necessary changes in master branch.
  • Update CHANGES.rst.
  • Cherry pick individual commits from master branch to release branch e.g. 2.9.x.
  • Check Travis CI to confirm passing tests in release branch e.g. 2.9.x.
  • Checkout release branch e.g.:
    git checkout -t remotes/origin/2.9.x
    $ git tag 2.9.1
    $ git push --tags
  • Create source distributions e.g.:
    $ make sdist

Plus release notes.

In https://github.com/python-pillow/Pillow/blob/5.1.x/docs/releasenotes/5.1.1.rst I put "... Xcode 6.4 to support at least 10.10 Yosemite" because it's not quite clear to me if 10.9 Mavericks is supported by Xcode 6.4, but we can change that if think it is.


Next up, resolve python-pillow/pillow-wheels#84.

@homm
Copy link
Member

homm commented Apr 25, 2018

Any plans for this?

@hugovk
Copy link
Member

hugovk commented Apr 25, 2018

If no further comments on python-pillow/pillow-wheels#84, let's merge it and go forward.

@wiredfool
Copy link
Member Author

yeah. go for it.

@hugovk
Copy link
Member

hugovk commented Apr 25, 2018

python-pillow/pillow-wheels#84 merged.


https://github.com/python-pillow/pillow-wheels has had three changes since last time:

Is that last one a problem? libwep 1.0.0 has been updated in python-pillow/Pillow in master (#3108) after 5.1.0. Should it also go into the 5.1.x branch?

@wiredfool
Copy link
Member Author

I'd rather not push a new version of webp in a point release given that it's not a current issue we're fixing and we've got 0 experience with it so far.

@hugovk
Copy link
Member

hugovk commented Apr 25, 2018

https://github.com/python-pillow/pillow-wheels/tree/5.1.x is the 5.1.0 release commit with just Xcode 6.4 and multibuild cherry-picked.

Building now, green so far: https://travis-ci.org/python-pillow/pillow-wheels/builds/371046996

I've done these next steps:


  • Create tag for release e.g.:
    $ git tag 2.9.1
    $ git push --tags
  • Create source distributions e.g.:
    $ make sdist

I don't have upload rights for the last steps, @wiredfool please could you finish off?

@yarikoptic
Copy link

this release being released would be much appreciated so Pillow is usable again on elderly OSX releases.

@hugovk
Copy link
Member

hugovk commented Jun 16, 2018

With 5.2.0 due out in two weeks (#3154), TODO if 5.1.1 is not released:

@hugovk
Copy link
Member

hugovk commented Jun 30, 2018

Let's release these in 5.2.0 (#3154) instead.

@hugovk hugovk closed this as completed Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants