Use y* instead of y#

[Yay295]

#6974 changed

Pillow/src/decode.c

Line 124 in dbcd737

if (!PyArg_ParseTuple(args, "y#", &buffer, &bufsize)) {

to use y* instead of y# so that it can accept a memoryview object, and notes that y* is actually the recommended way to accept binary data. y# is used in a few other locations; should these be changed as well?

Pillow/src/display.c

Line 201 in 7d8a08b

if (!PyArg_ParseTuple(args, "y#:frombytes", &ptr, &bytes)) {

Pillow/src/display.c

Line 721 in 7d8a08b

"y#(ii)(iiii):_load",

Pillow/src/encode.c

Line 567 in 7d8a08b

"ss|nnny#",

Pillow/src/encode.c

Line 1060 in 7d8a08b

"ss|nnnnnnnnOz#y#y#",

Pillow/src/_imaging.c

Line 1644 in 7d8a08b

if (!PyArg_ParseTuple(args, "sy#", &rawmode, &palette, &palettesize)) {

Pillow/src/_imaging.c

Line 1709 in 7d8a08b

if (!PyArg_ParseTuple(args, "y#", &values, &length)) {

Pillow/src/_imaging.c

Line 2220 in 7d8a08b

"y#y#",

Pillow/src/_imaging.c

Line 2544 in 7d8a08b

args, "O!y#", &Imaging_Type, &imagep, &glyphdata, &glyphdata_length)) {

Pillow/src/_imagingcms.c

Line 124 in 7d8a08b

if (!PyArg_ParseTuple(args, "y#:profile_frombytes", &pProfile, &nProfile)) {

Pillow/src/_imagingft.c

Line 142 in 7d8a08b

"etn|nsy#n",

Pillow/src/_imagingft.c

Line 1099 in 7d8a08b

list_name = Py_BuildValue("y#", name.string, name.string_len);

Pillow/src/_imagingft.c

Line 1145 in 7d8a08b

axis_name = Py_BuildValue("y#", name.string, name.string_len);

Pillow/src/_webp.c

Line 599 in 7d8a08b

"y#iiifss#iis#s#",

[radarhere]

Some of the code you've highlighted is using Py_BuildValue, which doesn't look like it takes y*..

Just to write it out, the other functions you've highlighted are WebPEncode_wrapper, getfont, cms_profile_fromstring, _font_new, _get_projection, _putpalettealphas, _putpalete, PyImaging_JpegEncoderNew, PyImaging_ZipEncoderNew, PyImaging_DrawWmf and _frombytes.

[radarhere]

I've created PR #6988 for _frombytes.

For some of methods, the data is read first. So there isn't a basic situation where the data passed to the C layer will be a memoryview.

• PyImaging_DrawWmf is only called internally from Image.core.drawwmf in

  Pillow/src/PIL/WmfImagePlugin.py

  Line 53 in 1457d2c

  Image.core.drawwmf(im.fp.read(), im.size, self.bbox),

• cms_profile_fromstring is only called internally from

  Pillow/src/PIL/ImageCms.py

  Lines 187 to 191 in 1457d2c

  	self._set(core.profile_frombytes(f.read()))
  	return
  	self._set(core.profile_open(profile), profile)
  	elif hasattr(profile, "read"):
  	self._set(core.profile_frombytes(profile.read()))

  .
• getfont is only called internally from

  Pillow/src/PIL/ImageFont.py

  Lines 236 to 255 in 1457d2c

  	def load_from_bytes(f):
  	self.font_bytes = f.read()
  	self.font = core.getfont(
  	"", size, index, encoding, self.font_bytes, layout_engine
  	)
  	if is_path(font):
  	if sys.platform == "win32":
  	font_bytes_path = font if isinstance(font, bytes) else font.encode()
  	try:
  	font_bytes_path.decode("ascii")
  	except UnicodeDecodeError:
  	# FreeType cannot load fonts with non-ASCII characters on Windows
  	# So load it into memory first
  	with open(font, "rb") as f:
  	load_from_bytes(f)
  	return
  	self.font = core.getfont(
  	font, size, index, encoding, layout_engine=layout_engine
  	)

For WebPEncode_wrapper, it is called from _webp.WebPEncode in

Pillow/src/PIL/WebPImagePlugin.py

Lines 340 to 341 in 1457d2c

	data = _webp.WebPEncode(
	im.tobytes(),

and im.tobytes() won't create a memoryview.

The other two instances were PyImaging_JpegEncoderNew and PyImaging_ZipEncoderNew. When I attempted to save a Pillow image to a memoryview, I got AttributeError: 'memoryview' object has no attribute 'write', so that isn't appropriate for that scenario.