Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Show diff when pre-commit fails #4716

Merged
merged 4 commits into from
Jun 28, 2020
Merged

CI: Show diff when pre-commit fails #4716

merged 4 commits into from
Jun 28, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jun 22, 2020 •
edited
Loading

Changes proposed in this pull request:

  • Sometimes pre-commit fails on the CI because the PR author doesn't have pre-commit installed
  • Show a diff of any changes it made, to help the author update the PR
  • And GitHub Actions doesn't have coloured output by default, so force it
  • Also update actions/cache to v2

Examples:

@hugovk hugovk added the Testing label Jun 22, 2020
@nulano
Copy link
Contributor

nulano commented Jun 22, 2020

I've been meaning to look into this, this has been annoying me so much, thank you!

@hugovk
Copy link
Member Author

hugovk commented Jun 22, 2020

Whilst we're adding colour to pre-commit, let's also add it to pytest.

@radarhere radarhere merged commit 77c098b into python-pillow:master Jun 28, 2020
@hugovk hugovk deleted the pre-commit-diff branch June 28, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @nulano @radarhere