Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleo exceptions don't use pep8 naming conventions (and pep8-naming flake8 plugin doesn't seem to care) #162

Closed
danieleades opened this issue Jun 9, 2022 · 2 comments · Fixed by #179
Milestone

Comments

@danieleades
Copy link
Contributor

Cleo's exceptions end in the suffix *Exception. PEP8 stipulates that exceptions should end in the suffix *Error. The pep8-naming flake8 extension is installed as a pre-commit hook, but is not triggering (for some reason).

see https://peps.python.org/pep-0008/#exception-names

@Secrus
Copy link
Member

Secrus commented Jul 4, 2022

I investigated this a bit. pep8-naming is adding this error to default ignore of flake8 config here. I think it's to be adjusted in flake8 config.

@Secrus
Copy link
Member

Secrus commented Jul 12, 2022

I tried activating the flake8 error, but with no luck. Might be just my lack of experience with configuring flake8. However, I don't think that *Exception is really wrong. I know it's not strictly in line with PEP8, but it's quite common to see it in projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants