Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitespace missing after URL in PEP508 string for URL Dependency #60

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Whitespace missing after URL in PEP508 string for URL Dependency #60

merged 1 commit into from
Aug 13, 2020

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Aug 13, 2020 •
edited by abn
Loading

At the end of an URL there must be a whitespace to represent the end of the url when representing in url dependency in PEP508 format.

Resolves: python-poetry/poetry#2802
Resolves: python-poetry/poetry#2824

  • Added tests for changed code.
  • Updated documentation for changed code.

@finswimmer finswimmer mentioned this pull request Aug 13, 2020
Closed
3 tasks
@finswimmer finswimmer requested a review from a team August 13, 2020 05:33
@abn abn merged commit b82168c into python-poetry:master Aug 13, 2020
@abn abn mentioned this pull request Aug 17, 2020
Closed
@sdispater sdispater mentioned this pull request Sep 18, 2020
Merged
@dimbleby dimbleby mentioned this pull request Jul 1, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abn abn abn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@finswimmer @abn