Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script version pinning? #70

Closed
jonapich opened this issue Oct 12, 2022 · 1 comment
Closed

Install script version pinning? #70

jonapich opened this issue Oct 12, 2022 · 1 comment
Labels
question Not an issue, but a question instead

Comments

@jonapich
Copy link

jonapich commented Oct 12, 2022

Can we get a documented way of pinning the install script? The suggested method of using curl on a URL that can point anywhere is not suitable for security and consistency reasons.

Our current workarounds:

  1. Keep a copy of the script in the repo
  2. Curl https://github.com/python-poetry/install.python-poetry.org instead, using a sha
@neersighted neersighted added the question Not an issue, but a question instead label Oct 12, 2022
@neersighted
Copy link
Member

From https://python-poetry.org/docs/#ci-recommendations:

Downloading a copy of the installer script to a place accessible by your CI pipelines (or maintaining a copy of the repository) is strongly suggested, to ensure your pipeline’s stability and to maintain control over what code is executed.

If you're interested in making what this script installs pinned, that would be #57 which is blocked by python-poetry/poetry-plugin-export#118.

@neersighted neersighted closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Not an issue, but a question instead
Projects
None yet
Development

No branches or pull requests

2 participants