-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Period(s) in repository "name" causes issues #1328
Comments
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This is still an issue. The following does not work, when parsing the property we either need to canonicalise the name or qoute the key. poetry config http-basic."foo.bar" username password |
@abn |
@abn Hi, can I work on this if available? |
Is this still an issue, as of August 2023? |
The relevant code that handles the parsing of name is at poetry/src/poetry/console/commands/config.py Lines 209 to 237 in 9b3893a
Fixing this also requires handling the repository configuration regexes, both fetching values and setting values. |
This seemed to be solved in main. @abn |
-vvv
option).Issue
Adding a custom
[[tool.poetry.source]]
whosename
includes a period causes issues when paired withhttp_basic
settings. Theadd_property
method on theConfigSource
object blindly splits on periods, including those in the repo name. The side effect of this is that the resulting TOML becomes very "deep."I'm happy to do a PR but I'm curious to know how much name checking is appropriate.
The text was updated successfully, but these errors were encountered: