Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry version command format first without bumping #1442

Closed
3 tasks done
Lothiraldan opened this issue Oct 6, 2019 · 2 comments
Closed
3 tasks done

Poetry version command format first without bumping #1442

Lothiraldan opened this issue Oct 6, 2019 · 2 comments
Labels
kind/bug Something isn't working as expected

Comments

@Lothiraldan
Copy link
Contributor

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

Issue

I have added a scripts section to my pyproject.toml at the end then I tried to run poetry version minor -vvv which seems to output the right thing:

Bumping version from 0.1.1 to 0.2.0

But checking the diff, the scripts section was only moved to its right place:

diff --git a/pyproject.toml b/pyproject.toml
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -13,9 +13,9 @@ python = "^2.7 || ^3.6 || ^3.7"
 
 [tool.poetry.dev-dependencies]
 
+[tool.poetry.scripts]
+mercurial-litf = "mercurial_litf.cli:main"
 [build-system]
 requires = ["poetry>=0.12"]
 build-backend = "poetry.masonry.api"
 
-[tool.poetry.scripts]
-mercurial-litf = "mercurial_litf.cli:main"

If I rerun once again poetry version minor -vvv, the version is correctly bumped:

diff --git a/pyproject.toml b/pyproject.toml
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "mercurial-litf"
-version = "0.1.1"
+version = "0.2.0"
 description = "A litf plugin for the Mercurial test runner"
 authors = ["Boris Feld <lothiraldan@gmail.com>"]
 license = "MIT"
@@ -13,9 +13,9 @@ python = "^2.7 || ^3.6 || ^3.7"
 
 [tool.poetry.dev-dependencies]
 
+[tool.poetry.scripts]
+mercurial-litf = "mercurial_litf.cli:main"
 [build-system]
 requires = ["poetry>=0.12"]
 build-backend = "poetry.masonry.api"
 
-[tool.poetry.scripts]
-mercurial-litf = "mercurial_litf.cli:main"

I can reproduce every time and I was on the latest release of poetry so it's not a regression on the 1.0.0b1.

I just wanted to confirm that it's indeed a bug before submitting a patch.

@Lothiraldan Lothiraldan added the kind/bug Something isn't working as expected label Oct 6, 2019
@finswimmer
Copy link
Member

Hey @Lothiraldan ,

could you please check the behavior with the latest preview? For me it works.

Thanks!

Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants