Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git dependencies are not cached #1698

Closed
2 tasks done
blaggacao opened this issue Dec 10, 2019 · 7 comments
Closed
2 tasks done

git dependencies are not cached #1698

blaggacao opened this issue Dec 10, 2019 · 7 comments
Labels
area/sources Releated to package sources/indexes/repositories area/vcs Related to support for VCS dependencies (Git and Dulwich) kind/enhancement Not a bug or feature, but improves usability or performance

Comments

@blaggacao
Copy link

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.

Issue

I checked the code and it seems the temp dir for git dependency installs are not cached. This is a bug-like behaviour for a 1.5 GB repository like https://github.com/odoo/odoo

@blaggacao blaggacao added the kind/bug Something isn't working as expected label Dec 10, 2019
@blaggacao
Copy link
Author

Maybe this issue can serve as an opportunity to streamline poetry.vcs.git with pygit2 libgit bindings...

@finswimmer finswimmer added the kind/feature Feature requests/implementations label Feb 6, 2020
@ubmarco
Copy link

ubmarco commented Mar 10, 2020

I also observed that a Git dependency given as

[tool.poetry.dependencies]
python = "^3.6"
click = "^7"
PyYAML = "*"
pdfplumber = { git = "https://github.com/jsvine/pdfplumber.git", rev = "df00787" }

will be cloned every time I do a poetry install, even if .venv/src/pdfplumber already contains the Git checkout with the right commit ID. I see no reason why an update is needed.
This prevents running tests when machines are offline.

@ldhieu
Copy link

ldhieu commented Jun 4, 2020

Having issues with this as well.

Does anyone have a temporary/quick fix for this ? Running poetry add with odoo in the pyproject file takes 20-30 mins everytime

@kshcherban
Copy link

Having issues with this as well.

Does anyone have a temporary/quick fix for this ? Running poetry add with odoo in the pyproject file takes 20-30 mins everytime

Just use odoo as a submodule in your git repo and change dependency from git to path.

@finswimmer finswimmer added the kind/enhancement Not a bug or feature, but improves usability or performance label Oct 16, 2020
@neersighted neersighted added area/vcs Related to support for VCS dependencies (Git and Dulwich) area/sources Releated to package sources/indexes/repositories and removed kind/bug Something isn't working as expected kind/feature Feature requests/implementations labels Oct 11, 2022
@dimbleby
Copy link
Contributor

#6131 should have avoided cloning when nothing has changed

@abn
Copy link
Member

abn commented Nov 16, 2024

This issue does not exist in Poetry 1.8.4 as the clone is reused if nothing has changed.

If the the issue still exists, or can be reproduced please create a new issue linking to this one as the codebase has changed significantly since this issue was raised.

@abn abn closed this as completed Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sources Releated to package sources/indexes/repositories area/vcs Related to support for VCS dependencies (Git and Dulwich) kind/enhancement Not a bug or feature, but improves usability or performance
Projects
None yet
Development

No branches or pull requests

8 participants