Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PEP-610 #2452

Closed
2 tasks done
sdispater opened this issue May 22, 2020 · 3 comments · Fixed by #3876
Closed
2 tasks done

Implement PEP-610 #2452

sdispater opened this issue May 22, 2020 · 3 comments · Fixed by #3876
Assignees
Labels
area/peps Related to PEP support/compliance kind/feature Feature requests/implementations
Milestone

Comments

@sdispater
Copy link
Member

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

pip recently added support for PEP-610 which gives the possibility to track the origin of an installed distribution via a direct_url.json file in the .dist-info directory.

This feature request is two-fold:

  • Properly read and handle the direct_url.json file. This will avoid some heuristics we do in the InstalledRepository class.
  • Generate the direct_url.json file when installing packages with Poetry. This is especially necessary since we will eventually move away from pip for the package installation.

Ideally, this should be implemented as soon as possible. However, since there are still quite a few features left to do for the 1.1 release, this might have to wait for the 1.2 release.

@sdispater sdispater added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels May 22, 2020
@sdispater sdispater added this to the Future milestone May 22, 2020
@sdispater sdispater modified the milestones: Future, 1.2 Jun 25, 2020
@mvoitko
Copy link

mvoitko commented Sep 14, 2020

Can I help with this?

@abn
Copy link
Member

abn commented Sep 14, 2020

@mvoitko sure thing, feel free to submit a draft PR. If you want guidance around the code base, ping me on our discord server. I will post some more details on here later.

@abn abn added area/peps Related to PEP support/compliance and removed status/triage This issue needs to be triaged labels Sep 14, 2020
@sdispater sdispater self-assigned this Mar 17, 2021
@sdispater sdispater mentioned this issue Apr 2, 2021
2 tasks
@abn abn closed this as completed in #3876 Apr 6, 2021
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/peps Related to PEP support/compliance kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants