Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to specify path to virtualenv / commandline #2575

Closed
2 tasks done
goodwillcoding opened this issue Jun 17, 2020 · 6 comments
Closed
2 tasks done

Add configuration to specify path to virtualenv / commandline #2575

goodwillcoding opened this issue Jun 17, 2020 · 6 comments
Labels
kind/feature Feature requests/implementations

Comments

@goodwillcoding
Copy link

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

Configuration setting to specify which virtualenv script to use.

Currently the virtualenv script is being looked for in the path, but for isolation issues it would be nice there could be a setting which sets the path to the virtualenv to use. Currently I work around this by having poetry run inside a virtualenv which seems like major overkill. Please let me know what you think of this.

Addititionally this setting could include the full call to virtualenv for example with "--no-download" and others which is crucial in isolated deployment.

@goodwillcoding goodwillcoding added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Jun 17, 2020
@finswimmer
Copy link
Member

Hello @goodwillcoding ,

there is already a feature request for this here: #1579

fin swimmer

@finswimmer finswimmer added status/duplicate Duplicate issues and removed status/triage This issue needs to be triaged labels Jun 20, 2020
@goodwillcoding
Copy link
Author

@finswimmer Are you sure that's the same bug, I found issue #1579 and read it as specifying path to an existing virtual environment. Which to me read differently then path to virtualenv script which will create environment.

@finswimmer
Copy link
Member

Which to me read differently then path to virtualenv script which will create environment.

@goodwillcoding: Oh, then I misunderstood your request. What should be the benefit of this? I don't think this will get included to poetry directly, but it sounds that this might be something for the upcoming plugin system

fin swimmer

@finswimmer finswimmer removed the status/duplicate Duplicate issues label Jun 21, 2020
@goodwillcoding
Copy link
Author

@finswimmer I've learned over the years is that having versions of virtualenv (and it's embedded packages) creates problems. Using specific virtualenv script (of specific version) has long added to stability and reproducibitly of the system.

@finswimmer
Copy link
Member

Can you give an example of such a script, so I can better understand the use case?

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

2 participants