Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass --prompt to be project name #3055

Closed
2 tasks done
Tadaboody opened this issue Oct 2, 2020 · 5 comments · Fixed by #5606
Closed
2 tasks done

Pass --prompt to be project name #3055

Tadaboody opened this issue Oct 2, 2020 · 5 comments · Fixed by #5606
Labels
kind/feature Feature requests/implementations

Comments

@Tadaboody
Copy link

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

Currently the prompt is either way too long in the case of generated global venvs, or useless in the case of .venv.
Virtualenv already supports passing --prompt to customize this, so I propose using the project name.

I do not use poetry env or anything other than one venv per project, so I'm open to propositions on other customization options.

@Tadaboody Tadaboody added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Oct 2, 2020
@abn
Copy link
Member

abn commented Oct 2, 2020

Maybe project name name and python version might be appropriate.

@abn abn added Good First Issue and removed status/triage This issue needs to be triaged labels Oct 2, 2020
@Tadaboody
Copy link
Author

Saw you added Good First Issue - already implementing ^_^

@Tadaboody
Copy link
Author

Also my gripe with having {name} {version} is that some prompts (like starship which I use) already display the python version :/
image

Actually I can configure that in starship so it's not that bad :U

@abn
Copy link
Member

abn commented Oct 2, 2020

The only reason why I mention the python version (atleast major and minor) is that majority shells do not have that :). The promt could just be something like py37. This is useful for users who have multiple environments.

This could in theory be also configurable in poetry config virtualenvs.prompt {project}-py{python}. See other configurations for using templates.

Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
2 participants