Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for git refs in poetry add #357

Closed
1 task done
dmfigol opened this issue Jul 29, 2018 · 6 comments
Closed
1 task done

Support for git refs in poetry add #357

dmfigol opened this issue Jul 29, 2018 · 6 comments
Labels
area/cli Related to the command line kind/feature Feature requests/implementations

Comments

@dmfigol
Copy link

dmfigol commented Jul 29, 2018

  • I have searched the issues of this repo and believe that this is not a duplicate.

Hi!
Thanks for the tool. Migrating from pipenv to poetry.
It would be great to see git refs support in poetry add. Every so often I install packages from Git branches/pull requests. Currently this syntax does not work:

-> % poetry add nornir --git https://github.com/nornir-automation/nornir.git@2.0

Updating dependencies
Resolving dependencies... (0.6s)

[CalledProcessError]
Command '['git', 'clone', 'https://github.com/nornir-automation/nornir.git@2.0', '/var/folders/js/jzwkkbb53nd7ns_53g069nlr0000gn/T/pyp
oetry-git-norniryq5f776b']' returned non-zero exit status 128.

add [-D|--dev] [--git GIT] [--path PATH] [-E|--extras EXTRAS] [--optional] [--python PYTHON] [--platform PLATFORM] [--allow-prereleases] [--dry-run] [--] <name> (<name>)...

I have to add it manually in pyproject.toml, but I would love to avoid that:

[tool.poetry.dependencies]
python = "*"
nornir = { git = "https://github.com/nornir-automation/nornir.git", branch = "2.0" }

I don't exclude that requested functionality is already available, but I could find it in the docs.
Thanks!

@agronholm
Copy link

There seems to be no way to specify the branch in poetry add but still this is somehow supported in pyproject.toml?

@sdispater sdispater added area/cli Related to the command line kind/feature Feature requests/implementations labels Mar 2, 2019
@floer32
Copy link

floer32 commented Mar 10, 2019

@agronholm yes it seems there are a number of features which are not supported on the command-line add, I'm personally not clear whether it's by design or just awaiting implementation

@im-n1
Copy link

im-n1 commented Sep 17, 2019

Just ran into this. This needs to be documented asap - it's really hard to figure out how to add your github repo fork. Please give it a few minutes and update the docs.

@Serkan-devel
Copy link

Does git dependency support exist in the current stable release or is it being rewritten?

@sdispater
Copy link
Member

This has been added in #1221 and is currently available in the latest prereleases of the 1.0.0 version.

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to the command line kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

6 participants