Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting the limitations of adding packages that depend on versions of CUDA #4124

Closed
caniko opened this issue Jun 1, 2021 · 3 comments
Closed
Labels
area/docs Documentation issues/improvements status/triage This issue needs to be triaged

Comments

@caniko
Copy link

caniko commented Jun 1, 2021

The documentation doesn't mention how to deal with situations in which the package to be added depends on version of external drivers such as CUDA. My specific case is that poetry can't detect the installed CUDA version appropriately when downloading from this repo. This repository is PEP 503 compliant.

My scenario:
I have added the repo to my pyproject.toml:

[[tool.poetry.source]]
name = "torch_rep"
url = "https://eternalphane.github.io/pytorch-pypi"

Lets say that I have CUDA 11.1 installed, what do I do? poetry add torch, just installs torch with ROCM when in fact I don't have an AMD GPU. CUDA or ROCM version on the computer should be detected, and if neither is present the fallback should be CPU.

From what I understand, this is a little outside of the scope of Poetry, and it would be nice to know why this isn't supported in the documentation. I think the Python ML community would appreciate a line or two about the problem, and potential solutions to pursue outside of poetry in the documentation.

PS:
For those wondering, the best solution at the moment would be to have separate package directories for cuda, rocm, and cpu on the PyPi repository; have cpu as the default for the poetry project, and install the alternative versions as extra.

@caniko caniko added area/docs Documentation issues/improvements status/triage This issue needs to be triaged labels Jun 1, 2021
@caniko caniko changed the title Adding packages that depend on versions of CUDA Documenting the limitations of adding packages that depend on versions of CUDA Jun 1, 2021
@caniko
Copy link
Author

caniko commented Jun 3, 2021

PEP 440 does sum up the issue; moreover, I still think a sentence or two with an exemplary implementation would be nice.

@ralbertazzi
Copy link
Contributor

Closing as it doesn't add more than #6409 and #2613

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements status/triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants