Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"This installer is deprecated" with recommended install #4128

Closed
3 tasks done
nzig opened this issue Jun 2, 2021 · 6 comments
Closed
3 tasks done

"This installer is deprecated" with recommended install #4128

nzig opened this issue Jun 2, 2021 · 6 comments
Labels
kind/bug Something isn't working as expected

Comments

@nzig
Copy link

nzig commented Jun 2, 2021

  • I am on the latest Poetry version.

  • I have searched the issues of this repo and believe that this is not a duplicate.

  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

  • OS version and name: Docker image python:3.9.5-buster

  • Poetry version: Installing from master

  • Link of a Gist with the contents of your pyproject.toml file: Not relevant

Issue

When installing Poetry according to the documentation by running

curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | python -

The following warnings is printed:

This installer is deprecated. Poetry versions installed using this script will not be able to use 'self update' command to upgrade to 1.2.0a1 or later.

This seems to be because of c28728f. I think the root of the issue is that the instructions recommend you use master to install the current version (1.1), but master has already been updated to the 1.2 situation with the deprecation.

I think either the recommended install should use the 1.1 branch, or master should be reverted not to issue deprecation warnings until 1.2 is released.

@nzig nzig added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jun 2, 2021
@nzig nzig changed the title "This installer is deprecated." with recommended install "This installer is deprecated" with recommended install Jun 2, 2021
@finswimmer
Copy link
Member

Hello,

the get-poetry.py script doesn't care if its from the master branch or 1.1. It receives the version to install from https://github.com/python-poetry/poetry/releases.

The deprecation warnings arises because this script will be replaced by the install-poetry.py' script in the future. The scripts differ in the way how and where poetry is installed. This is why you will not be able to run poetry self updateto update to 1.2.0a1 or later when installing withget-poetry.py`. Version 1.2.0a1 depends on the new way of installing.

fin swimmer

@nzig
Copy link
Author

nzig commented Jun 18, 2021

Thank you for your response and your work on Poetry.

I understand that get-poetry.py install the version from releases, but the code of get-poetry.py itself does depend on the branch, and it's currently issuing a warning that is not yet relevant until 1.2 is released.

I just think it's a bad user experience to follow the official instructions and get a deprecation warning, even though there's nothing you can do about it. If this is the intent, maybe the wording should be changed to still warn the user that 1.2 will require a reinstall, without sending them searching for the non-deprecated installer which isn't released yet.

Thanks again!

@TRiggAtGM
Copy link

I know this issue is closed but I think @nzig brings up a very valid and important point. I'm relatively positive that I'm not the only person who clicked the little thumbs up on his comment because we wound up here googling "Okay, so how am I supposed to install poetry if the script from the documentation is the wrong way to do this"

I think perhaps the wording should be changed from saying "This script is deprecated" to something like

NOTICE: In the near future this script will be deprecated. If you are using it to install a version prior to 1.2, you should be fine

@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
@StevenClontz
Copy link

StevenClontz commented Jun 21, 2022

I'm relatively positive that I'm not the only person who clicked the little thumbs up on his comment because we wound up here googling "Okay, so how am I supposed to install poetry if the script from the documentation is the wrong way to do this"

I can confirm as this is exactly why I'm here. Maybe just an update to the docs saying you can ignore that message for now would be a sufficient fix. I nearly uninstalled thinking I had messed something up!

@zoltan-spire
Copy link

zoltan-spire commented Jun 23, 2022

I second the previous comments, better wording could save folks some time searching for the non-deprecated installation method.

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

6 participants