Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interested in supporting PEP 665? #4710

Closed
2 tasks done
brettcannon opened this issue Nov 4, 2021 · 5 comments
Closed
2 tasks done

Interested in supporting PEP 665? #4710

brettcannon opened this issue Nov 4, 2021 · 5 comments
Labels
area/peps Related to PEP support/compliance kind/feature Feature requests/implementations

Comments

@brettcannon
Copy link

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Issue

I'm writing to all of the major packaging projects to see if they would be willing to give me a quote of support for PEP 665? For Poetry this could mean two things:

  1. Eventually replacing Poetry.lock with what the PEP defines.
  2. Support for exporting to what the PEP defines.

The current draft and discussion is at https://discuss.python.org/t/pep-665-take-2-a-file-format-to-list-python-dependencies-for-reproducibility-of-an-application/11736 . If Poetry would be interested in stating that the project supports the PEP (in some form), could you please let me know or leave a comment on Discourse?

Thanks!

@neersighted neersighted added kind/feature Feature requests/implementations area/peps Related to PEP support/compliance labels Nov 11, 2021
@sdispater
Copy link
Member

As the PEP stands, I don't think Poetry can fully support it, either as its primary lock file or via the export command. The main issue is that Poetry supports sdists files, directory and VCS dependencies which are not supported by the PEP so that would be a huge regression from a feature standpoint.

Also, the fact that requirements are at the file level in the PEP is contradictory to the design of Poetry which works at the version level, and there is no plan to change that any time soon since it would prove to be a headache from a dependency resolution standpoint.

@brettcannon
Copy link
Author

As the PEP stands, I don't think Poetry can fully support it, either as its primary lock file or via the export command. The main issue is that Poetry supports sdists files, directory and VCS dependencies which are not supported by the PEP so that would be a huge regression from a feature standpoint.

Supporting sdists in the PEP is being discussed. The expectation, though, is if we leave out of this PEP it will be added in a subsequent PEP.

Also, the fact that requirements are at the file level in the PEP is contradictory to the design of Poetry which works at the version level, and there is no plan to change that any time soon since it would prove to be a headache from a dependency resolution standpoint.

So that means even if sdists went in you still wouldn't support exporting? I want to make sure I represent your views appropriately in the PEP.

@sdispater
Copy link
Member

Supporting sdists in the PEP is being discussed. The expectation, though, is if we leave out of this PEP it will be added in a subsequent PEP.

That means that Poetry won't be able to support until the file format is final and supports sdists and, at least, VCS packages.

So that means even if sdists went in you still wouldn't support exporting? I want to make sure I represent your views appropriately in the PEP.

Exactly. The export command of Poetry exports the information present in the poetry.lock file into another format. That means that this other format should support the same set of package specification as Poetry's otherwise users would lose information and packages.

@brettcannon
Copy link
Author

Thanks for the feedback. I recorded it in the PEP at python/peps@6bbde29 and also stated it on the topic at discuss.python.org.

Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/peps Related to PEP support/compliance kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

3 participants