Dependency solver ignores python_version in required packages

[m-dz]

• I am on the latest Poetry version.
• I have searched the issues of this repo and believe that this is not a duplicate.
• If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

• OS version and name: Ubuntu 20.04 LTS (Focal Fossa), via Windows 10 WSL2
• Poetry version: 1.1.12
• Link of a Gist with the contents of your pyproject.toml file: https://gist.github.com/m-dz/cb43fb4085c83eb614b86b72f5928d8a
• Python version: 3.7.12

Issue

Running poetry install -vvv fails on dependencies resolving step for google-colab:

Resolving dependencies...
   1: fact: demo is 0.0.1
   1: derived: demo
   1: fact: demo depends on google-colab (*)
   1: fact: demo depends on numpy (*)
   1: fact: demo depends on pandas (>=1.3.0)
   1: selecting demo (0.0.1)
   1: derived: pandas (>=1.3.0)
   1: derived: numpy
   1: derived: google-colab
   1: fact: google-colab (1.0.0) depends on google-auth (>=1.4.0,<1.5.0)
   1: fact: google-colab (1.0.0) depends on ipykernel (>=4.6.0,<4.7.0)
   1: fact: google-colab (1.0.0) depends on ipython (>=5.5.0,<5.6.0)
   1: fact: google-colab (1.0.0) depends on notebook (>=5.2.0,<5.3.0)
   1: fact: google-colab (1.0.0) depends on six (>=1.12.0,<1.13.0)
   1: fact: google-colab (1.0.0) depends on pandas (>=0.24.0,<0.25.0)
   1: fact: google-colab (1.0.0) depends on portpicker (>=1.2.0,<1.3.0)
   1: fact: google-colab (1.0.0) depends on requests (>=2.21.0,<2.22.0)
   1: fact: google-colab (1.0.0) depends on tornado (>=4.5.0,<4.6.0)
   1: derived: not google-colab (==1.0.0)
   1: fact: no versions of google-colab match !=1.0.0
   1: conflict: no versions of google-colab match !=1.0.0
   1: !  google-colab (!=1.0.0) is partially satisfied by not  google-colab (1.0.0)
   1: ! which is caused by "google-colab (1.0.0) depends on pandas (>=0.24.0,<0.25.0)"
   1: ! thus: every version of google-colab requires pandas (>=0.24.0,<0.25.0)
   1: !  google-colab (*) is satisfied by  google-colab (*)
   1: ! which is caused by "demo depends on google-colab (*)"
   1: ! thus: pandas is required
   1: ! not  pandas (>=0.24.0,<0.25.0) is satisfied by  pandas (>=1.3.0)
   1: ! which is caused by "demo depends on pandas (>=1.3.0)"
   1: ! thus: version solving failed
   1: Version solving took 0.352 seconds.
   1: Tried 1 solutions.

  SolverProblemError

  Because no versions of google-colab match !=1.0.0
   and google-colab (1.0.0) depends on pandas (>=0.24.0,<0.25.0), every version of google-colab requires pandas (>=0.24.0,<0.25.0).
  So, because demo depends on both google-colab (*) and pandas (>=1.3.0), version solving failed.

  at ~/.local/share/pypoetry/venv/lib/python3.7/site-packages/poetry/puzzle/solver.py:241 in _solve
      237│             packages = result.packages
      238│         except OverrideNeeded as e:
      239│             return self.solve_in_compatibility_mode(e.overrides, use_latest=use_latest)
      240│         except SolveFailure as e:
    → 241│             raise SolverProblemError(e)
      242│
      243│         results = dict(
      244│             depth_first_search(
      245│                 PackageNode(self._package, packages), aggregate_package_nodes

whereas google-colab 1.0.0 on Python 3.7.1 should use pandas>=1.1.0 according to https://github.com/googlecolab/colabtools/blob/main/setup.py#L30:

DEPENDENCIES = (
    [...]
    'pandas~=0.24.0; python_version < "3.0"',
    'pandas>=1.1.0; python_version >= "3.0"',
    [...]
)

Comments

I believe this might be related to #2187

[finswimmer]

Hey @m-dz,

the version in the github repo is not the same as the version available on pypi.

There you'll find this in the setup.py:

DEPENDENCIES = (
    # Note: these dependency versions should be kept in-sync with the versions
    # specified in the docker container requirements files.
    'google-auth~=1.4.0',
    'ipykernel~=4.6.0',
    'ipython~=5.5.0',
    'notebook~=5.2.0',
    'six~=1.12.0',
    'pandas~=0.24.0',
    'portpicker~=1.2.0',
    'requests~=2.21.0',
    'tornado~=4.5.0',
)

fin swimmer

[m-dz]

Ugh, thank you and apologies for suspecting the fault of Poetry here. I'll try to raise this with the other side.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.